FLUID-1186: Drop target does not apper below last item in a sortable list

Metadata

Source
FLUID-1186
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Justin Obara
Created
2008-08-18T11:01:08.000-0400
Updated
2008-08-27T13:55:28.000-0400
Versions
  1. 0.4
Fixed Versions
  1. 0.5beta1
Component
  1. Reorderer

Description

No drop target appears below the last item in a sortable list.

You can still drop an element below the list as long as the last list item takes up more than one line.

Steps to reproduce:

1) Open the sortable vertical list example from the daily build site:
http://build.fluidproject.org/fluid/sample-code/reorderer/todo-list/sortable-styled-todo-list.html

2) Attempt to drag and drop an item to the last position. Notice that no drop target appears.

dev-iteration41

Environments

IE 6 (Win XP)

Comments

  • Justin Obara commented 2008-08-18T11:03:19.000-0400

    You can actually still perform the drag and drop operation if the last item is only one line, it is just harder.

  • Simon Simon commented 2008-08-22T18:29:29.000-0400

    This should be a CSS styling issue. I changed .orderable-drop-marker's margin to 2px, and then the two associated issues disappear:
    1. the drop marker appears when drag and drop an item to the last position.
    2. when the last position is a one line component, the drop marker appears when drag and drop an item to the last position.

    I tested in both IE6, and Firefox 2. All work correctly.

    A few more style changes may make it look better:
    (1) change .orderable-avatar's width from 300px to auto. This can prevent the content wraps in the avatar.
    (2) add .orderable-avatar's list-style-type to none. This can prevent the avatar has a list sequence number assigned to it.

  • Antranig Basman commented 2008-08-25T18:59:17.000-0400

    I believe that this is "essentially" a duplicate of FLUID-1125. The fix here is good for this specific sample, but ideally I think that whilst we always want to allow room for users to improve and "tweak" component behavaiour with styling fixes, this component should work well under a broad variety of styling choices and not be dependent on individual ingenuity to get correct basic behaviour 😛 Hopefully this will be resolved more globally as part of the overall umbrella of FLUID-1148.

  • Michelle D'Souza commented 2008-08-27T12:39:29.000-0400

    True, we expect components to work with a variety of styling however, the styling of this particular example was quite strange to begin with. It included a margin of "-2px". It's possible that the negative margin was causing the weird behaviour.

  • Michelle D'Souza commented 2008-08-27T12:40:17.000-0400

    This issue was fixed with a styling change for the 0.5 beta and is expected to go away once the overhaul of the reorderer is complete.

  • Justin Obara commented 2008-08-27T13:55:28.000-0400

    Verified fix using IE 6 (Win XP)