FLUID-2369: The thumb of the slider is positioned to the far left when the dialog opens

Metadata

Source
FLUID-2369
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Michelle D'Souza
Reporter
Justin Obara
Created
2009-03-17T12:39:54.000-0400
Updated
2009-03-23T15:31:33.000-0400
Versions
  1. 1.0
Fixed Versions
N/A
Component
  1. UI Options

Description

The thumb of the slider is positioned to the far left when the dialog opens

Steps to reproduce

1) Open the sakai mock-up from the daily build site
http://build.fluidproject.org/fluid/sample-code/shared/sakai/sakai.html#

2) Open the UI Options dialog

Notice that the thumbs of the sliders are positioned to the far left. This is even the case if you have previously increased the size.

Environments

FF2, FF3, Opera 9.6, Safari 3.2 (Mac OS 10.5)
Safari 3.2 (Mac OS 10.4)
FF2, FF3, IE6, IE7, Opera 9.6 (Win XP)
FF3, IE7 (Win Vista)
IE6 (Win 2000)

Comments

  • Justin Obara commented 2009-03-19T09:19:55.000-0400

    Bug Parade 1.0 release

  • Justin Obara commented 2009-03-19T09:21:14.000-0400

    also happens on cancel

  • Anastasia Cheetham commented 2009-03-23T12:03:50.000-0400

    I've reviewed the code changes for this issue. They look good, but:

    The fix essentially implements the ability to set a default for min. text size and for text spacing. Given that all other values in the UI Options dialog have defaults set, I'm wondering if we should set defaults for these two now?

    I'm not sure if this question should be addressed as part of this issue, or if we should open another one.

  • Michelle D'Souza commented 2009-03-23T12:19:12.000-0400

    It's not actually a default that the fix sets - at least, that wasn't my intention. My intention was to read the saved settings of the user and show them on the user interface. I think it would be fine to set a default for line spacing since there is a natural default of 1. The problem with setting a default for minimum text size is that it has side effects that we may not want. Setting a minimum text size is the user saying "I can't see anything smaller then this", so we remove FSS styling that would make the font size smaller such as 'fl-font-size-90'. We shouldn't do this unless the user actually says they have a minimum text size.

  • Anastasia Cheetham commented 2009-03-23T14:10:59.000-0400

    After discussing this issue with Michelle and Jacob, this has been clarified. The implementation of the fix to this issue is good, and default values are not required.

  • Justin Obara commented 2009-03-23T15:31:33.000-0400

    Verified fix using:

    FF2, FF3, Opera 9.6, Safari 3.2 (Mac OS 10.5)
    FF2, FF3, IE6, Opera 9.6 (Win XP)
    FF3, IE7 (Win Vista)