FLUID-2765: The .fl-ProgEnhance-basic and .fl-ProgEnhance-enhanced class names don't follow our standard conventions.

Metadata

Source
FLUID-2765
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Colin Clark
Created
2009-05-25T12:49:53.000-0400
Updated
2009-05-26T17:17:14.000-0400
Versions
  1. 1.0
Fixed Versions
  1. 1.1
Component
  1. FSS

Description

Our progressive enhancement features rely on two CSS class names: .fl-ProgEnhance-basic and .fl-ProgEnhance-enhanced. These don't follow our standard conventions, which are described here:

http://wiki.fluidproject.org/display/fluid/Class+Name+Conventions

Let's rename these to .fl-progEnhance-basic and .fl-progEnhance-enhanced, providing backwards compatibility for the incorrect names. This will require changes in the FSS layout file as well as ProgressiveEnhancement.js

Comments

  • Justin Obara commented 2009-05-25T13:01:32.000-0400

    Bug Parade 1.1 release

  • Anastasia Cheetham commented 2009-05-25T15:00:11.000-0400

    The classes have been renamed.

  • Anastasia Cheetham commented 2009-05-25T15:18:39.000-0400

    Didn't ensure backward compatibility... oops

  • Anastasia Cheetham commented 2009-05-25T15:37:47.000-0400

    I've added backward compatibility with the old names, marked as "deprecated". Needs review!

  • Jacob Farber commented 2009-05-26T14:45:36.000-0400

    I made some small syntactic changes, but everything else looked good. Looks like the ball is now in someone elses court!

  • Antranig Basman commented 2009-05-26T14:53:57.000-0400

    Reviewed this most recent change as +1

  • Justin Obara commented 2009-05-26T17:17:13.000-0400

    Verified fix using:

    FF3 (Mac OS 10.5)