FLUID-2967: Item will drop to the right of an element when it should have dropped at the left.

Description

Item will drop to the right of an element when it should have dropped at the left.

Steps to reproduce:

1) Open the sortable jQuery UI Tabs example
http://build.fluidproject.org/infusion/standalone-demos/reorderer/html/jquery-tabs.html

2) Using the mouse drag a tab over one of the middle tabs

3) Place it as far to the right as possible, without the drop target moving from the desired location

4) Notice that when you drop the avatar, it will be inserted one place to the right of where it should have dropped.

Environments

FF2, FF3, Opera 9.6, Safari 3.2 (Mac OS 10.5)
Safari 3.2 (Mac OS 10.4)
FF2, FF3, IE6, IE7, IE8, Opera 9.6 (Win XP)
FF3, IE7, IE8 (Win Vista)
IE6 (Win 2000)

Attachments

• FLUID-2967.patch
• FLUID-2967-b.patch

Comments

• Justin Obara commented 2009-07-27T16:12:14.000-0400

  Bug Parade 1.1.1 release

• Antranig Basman commented 2009-08-04T15:06:21.000-0400

  Fundamental error in permuteDom algorithm - fixed with additional test cases

• Antranig Basman commented 2009-08-04T15:43:55.000-0400

  Secondary patch to correct keyboard navigation issue

• Antranig Basman commented 2009-08-04T16:20:38.000-0400

  Fixed and committed to both trunk and the 1.1.1 branch - this was quite a complex issue since there was an error in the underlying fluid.permuteDom algorithm implementation (hidden by a couple of missing test cases), which bug had then been compensated for at a higher level, in particular in the implementation of the gridReorderer. As a result of the bug, the layoutHandler for the gridReorderer was spuriously equivalent to the standard geometricStrategy (which happened to be used also in the layoutReorderer). With this bug fixed, these two implementations may no longer coincide and the gridReorderer needs its own, slightly tweaked, geometric strategy for the perpendicular direction.

• Michelle D'Souza commented 2009-08-06T16:34:07.000-0400

  I ran some quick tests and this issues appears to be fixed. I looked at the patch and I can see that Antranig has added a strategy for grid layout handling. Unfortunately I don't know the code base well enough to notice an nuances in this code. I think this needs to be well tested.

• Justin Obara commented 2009-08-07T09:02:14.000-0400

  Tested using:

  FF2, FF3, FF3.5, Opera 9.6, Safari 3.2, Safari 4 (Mac OS 10.5)
  FF3, IE7, IE8 (Win Vista)

  Appears to be working properly