FLUID-6610: Panel index update through rendering can race against preference saving in separatedPanelPrefsEditor tests

Metadata

Source
FLUID-6610
Type
Bug
Priority
Major
Status
Reopened
Resolution
N/A
Assignee
Antranig Basman
Reporter
Antranig Basman
Created
2021-03-29T09:46:42.388-0400
Updated
2024-07-17T08:10:19.293-0400
Versions
N/A
Fixed Versions
N/A
Component
  1. Prefs Framework

Description

As part of an entirely unrelated update purely affecting styling, a relatively consistent race was introduced in the SeparatedPanel prefs editor tests in https://github.com/fluid-project/infusion/pull/1042

This lost fairly consistently in Firefox on Ubuntu and sometimes on MacOS.

The "old" framework (prior to FLUID-6148 update) would tend to race model updates on initialisation. In order to make the test reliable, we should restrict the test to only compare the part of the model that contains preferences -

e.g. to change this line https://github.com/fluid-project/infusion/blob/main/tests/framework-tests/preferences/js/SeparatedPanelPrefsEditorTests.js#L149 to read

jqUnit.assertDeepEq("Only the changed preferences are saved", fluid.tests.prefs.bwSkin.preferences, storedSettings.preferences);