Metadata
- Source
- KETTLE-44
- Type
- Task
- Priority
- Major
- Status
- Resolved
- Resolution
- Fixed
- Assignee
- Antranig Basman
- Reporter
- Tony Atkins [RtF]
- Created
2016-06-07T07:09:22.331-0400 - Updated
2016-06-08T14:56:47.712-0400 - Versions
- N/A
- Fixed Versions
- N/A
- Component
- N/A
Description
Following up on FLUID-5120, we should update Kettle to:
1. Use ESLint and remove JSHint
2. Use a 1.0.x version of Grunt and all Grunt plugins.
@@Antranig Basman, I was planning to submit a small PR for this unless you, @@Cindy Li, or someone else on the team was already taking it on.
Comments
-
Tony Atkins [RtF] commented
2016-06-07T07:09:55.490-0400 We need some small discussion around the right "strict" setting before this can proceed:
-
Tony Atkins [RtF] commented
2016-06-07T07:59:33.543-0400 I proceeded with everything else (including a new Gruntfile, etc.). I would also like to add a "test" script to the package.json, but get odd errors when doing so. @@Antranig Basman, we should look at this together, it should not take more than five minutes.
-
Tony Atkins [RtF] commented
2016-06-07T08:09:32.963-0400 Here is the branch:
https://github.com/the-t-in-rtf/kettle/tree/KETTLE-44
If I run
node tests/all-tests.js, I get:> node test/all-tests.js function -
Tony Atkins [RtF] commented
2016-06-07T15:34:22.292-0400