KETTLE-72: kettle.loadTestingSupport fails because of missing form-data dependency

Metadata

Source
KETTLE-72
Type
Bug
Priority
Major
Status
Resolved
Resolution
Fixed
Assignee
Alan Harnum
Reporter
Tony Atkins [RtF]
Created
2018-08-29T04:49:27.581-0400
Updated
2018-10-04T09:58:20.702-0400
Versions
  1. 1.8.0
Fixed Versions
N/A
Component
N/A

Description

@@Alan Harnum recently added new functionality to Kettle, which requires the form-data module. That dependency is currently a dev dependency. The net result is that calling kettle.loadTestingSupport() from another package now results in errors like:

10:45:41.189:  FATAL ERROR: Uncaught exception: Cannot find module 'form-data'
Error: Cannot find module 'form-data'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/duhrer/Source/rtf/gpii-testem/node_modules/kettle/lib/test/KettleTestUtils.form.js:19:16)
    at Module._compile (module.js:570:32)
    at Module.replacementCompile (/Users/duhrer/Source/rtf/gpii-testem/node_modules/nyc/node_modules/append-transform/index.js:58:13)
    at Module._extensions..js (module.js:579:10)
    at Object.<anonymous> (/Users/duhrer/Source/rtf/gpii-testem/node_modules/nyc/node_modules/append-transform/index.js:62:4)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.kettle.loadTestingSupport (/Users/duhrer/Source/rtf/gpii-testem/node_modules/kettle/kettle.js:40:5)

The solution is to move the dependency into the main block.

Comments