Metadata
- Source
- SJRK-106
- Type
- Task
- Priority
- Blocker
- Status
- Closed
- Resolution
- Done
- Assignee
- N/A
- Reporter
- Gregor Moss
- Created
2018-05-31T15:04:32.068-0400 - Updated
2018-12-04T11:25:10.369-0500 - Versions
- N/A
- Fixed Versions
- N/A
- Component
-
- Storytelling Tool UI
Description
The CSS class names used throughout the project are somewhat inconsistent, and should be brought into a more consistent state. They should also conform to CSS class name conventions.
E.g. we have classes like "sjrk-storyTelling-....", "sjrk-storyTelling-block-....", "sjrk-storyblock.." et cetera. This is inconsistent and potentially confusing. They are also using uppercase letters, which are verboten.
Comments
-
Gregor Moss commented
2018-12-03T11:00:43.827-0500 After careful consideration and reviewing other projects in fluid-project and fluid-lab repositories, I have chosen to make the following changes:
- "sjrk-storyTelling-..." and "sjrkc-storyTelling-..." will become "sjrk-st-..." and "sjrkc-st-..." respectively
- "sjrk-storyblock-block-..." and "sjrkc-storyblock-block-..." will "sjrk-st-block-..." and "sjrkc-st-block-..." respectively
- "sjrk-storyblock-..." and "sjrkc-storyblock-..." will "sjrk-st-block-..." and "sjrkc-st-block-..." respectively
the latter two should not have any collisions within the newly-combined "block" classes
-
Gregor Moss commented
2018-12-03T18:03:07.535-0500 Removed a couple of unused classes from the CSS file as well:
- .sjrk-storyTelling-label-container (only a pseudoselector on this is being used, currently)
- .sjrk-storyTelling-story-previewPane
- .sjrk-storyTelling-storyPreview