VP-176: Restructure the captions model to avoid the need for code logic in the caption controls

Metadata

Source
VP-176
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Anastasia Cheetham
Reporter
Anastasia Cheetham
Created
2012-02-03T14:05:28.349-0500
Updated
2013-01-28T09:25:24.493-0500
Versions
N/A
Fixed Versions
N/A
Component
N/A

Description

There is a lot of unnecessary logic in fluid.videoPlayer.controllers.captionControls.bindCaptionModel(). Restructuring the caption portion of the model should allow a simplification of the code.

Comments

  • Anastasia Cheetham commented 2012-02-03T14:32:03.631-0500

    I started the work of adding guard listeners to move the logic into the model and out of the code:
    https://github.com/acheetham/videoPlayer/tree/FLUID-4589-captionControls-model-restructuring
    This branch is still messy and doesn't work.

    We also decided to try the new jQuery menu widget from the pre-1.9 release. This hasn't been started, but would be done as part of this JIRA. The model restructuring I did so far might have to change for the menu, and the markup and rendering certainly will.

  • Michelle D'Souza commented 2012-03-07T17:03:18.485-0500

    Merged into the demo branch at 0fc93b9cccef4bf35e817aae8ea303f7712724dd